fix(mpu-regions): Fix find region function on arm-r MPU #267
+15
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelafsilva5
requested review from
DavidMCerdeira,
danielRep and
josecm
as code owners
josecm
approved these changes
Nov 6, 2025
Make MPU region lookups ASID-aware to avoid cross-address-space matches, and merge the two find helpers into a single mpu_find_region(struct mp_region*, asid_t) that matches by base and ASID. Signed-off-by: Miguel Silva <[email protected]>
Signed-off-by: Miguel Silva <[email protected]>
miguelafsilva5
force-pushed
the
fix/mpu-regions
branch
from
6c23aa7 to
06c615b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
The
mpu_find_region_baseandmpu_find_region_exacton arm-r MPU driver were failing to find some regions that had the same base. These function only checked the first region that matched the base. Furthermore, they didn't validate that the region belong to the address space using the mpu update or unmap.This PR fixes this problem by merging both function in one and adding a check to the asid owner of each region. This solves the problem because the vmpu driver ensures that there is only a single region with the same base per AS.
Another function was removed because is was a single if statement and it was being used only once throughout the code.